add clarifying info on how MF joins works #6690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
runleonarun
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Hey @mirnawong1, I made some suggestions for simplifying the language a little and possibly moving content if it makes sense!
|
|
||
| This table primarily represents left joins unless otherwise specified. For scenarios involving multiple `fct` models, MetricFlow uses full outer joins. | ||
|
|
||
| ### Explanation of joins |
There was a problem hiding this comment.
I think these definitions would be helpful to read before the bullets above.
There was a problem hiding this comment.
moved them and consolidated content:
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
|
thanks @runleonarun and great flags! have made add'l tweaks and would love a re-review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds more detail about the joins supported by mf. currently it mentions left joins but there's no info on outer joins or semantic valiations. this pr adds more info on the types of joins available, when they're used, semantic validations available, and practical sql examples
raised by internal slack
Resolves #6650
🚀 Deployment available! Here are the direct links to the updated files: